On 03/10/2016 01:31 PM, Marc-André Lureau wrote:
QEMU (somewhere around 2.0) added a new sub-option to the -name flag -name debug-threads=on
This causes the naming of individual QEMU threads to be helpful; e.g. 'CPU/KVM 0' or 'migration' these show up in top once the H key is pressed, and also show up in a core dump, making it easy to figure out which thread is which.
The following 2 patches add a capability check and enable debug-threads if supported.
Related to: https://bugzilla.redhat.com/show_bug.cgi?id=1140121
cheers
v2->v3: - move -name command generation in seperate function - fix syntax-check - fix leak
v1->v2: - drop the configuration, enable debug-thread automatically
Marc-André Lureau (2): qemu: check for debug-threads capability qemu: enable debug threads
src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 40 ++++++++++++++++++++++------ tests/qemucapabilitiesdata/caps_2.1.1-1.caps | 1 + tests/qemucapabilitiesdata/caps_2.4.0-1.caps | 1 + tests/qemucapabilitiesdata/caps_2.5.0-1.caps | 1 + tests/qemucapabilitiesdata/caps_2.6.0-1.caps | 1 + 7 files changed, 39 insertions(+), 8 deletions(-)
Also needs a test case for argv generation... qemuxml2argv is the best place even though it's not XML specific - Cole