On 04/12/15 20:30, Pavel Hrdina wrote:
Signed-off-by: Pavel Hrdina <phrdina@redhat.com> ---
Again, the patch is lacking commit message, feel free to re-use the one you'll provide for 1/7 in some way.
src/lxc/lxc_driver.c | 5 ++++- src/lxc/lxc_native.c | 8 +++++++- src/lxc/lxc_native.h | 4 +++- tests/Makefile.am | 2 +- tests/lxcconf2xmldata/lxcconf2xml-blkiotune.xml | 3 ++- tests/lxcconf2xmldata/lxcconf2xml-cpusettune.xml | 3 ++- tests/lxcconf2xmldata/lxcconf2xml-cputune.xml | 3 ++- tests/lxcconf2xmldata/lxcconf2xml-idmap.xml | 3 ++- tests/lxcconf2xmldata/lxcconf2xml-macvlannetwork.xml | 3 ++- tests/lxcconf2xmldata/lxcconf2xml-memtune.xml | 3 ++- tests/lxcconf2xmldata/lxcconf2xml-nonenetwork.xml | 3 ++- tests/lxcconf2xmldata/lxcconf2xml-nonetwork.xml | 3 ++- tests/lxcconf2xmldata/lxcconf2xml-physnetwork.xml | 3 ++- tests/lxcconf2xmldata/lxcconf2xml-simple.xml | 3 ++- tests/lxcconf2xmldata/lxcconf2xml-vlannetwork.xml | 3 ++- tests/lxcconf2xmltest.c | 18 +++++++++++++++++- 16 files changed, 54 insertions(+), 16 deletions(-)
@@ -93,6 +98,14 @@ mymain(void) { int ret = EXIT_SUCCESS;
+ if (!(caps = testLXCCapsInit())) + return EXIT_FAILURE; + + if (!(xmlopt = lxcDomainXMLConfInit())) { + virObjectUnref(caps);
looking at this ^^, it should also be fixed in lxcxml2xmltest.c (but within a separate patch) since this is supposed to be a tweak/refactor series.
+ return EXIT_FAILURE; + } +
ACK with those little adjustments after 1.3.0 release (same applies to 1/7). Erik