Re: [PATCH 09/10] virDomainDriverAutoShutdownDoSave: Don't attempt to save transient VMs

4 Jul 2025


      On Thu, Jul 03, 2025 at 02:50:32PM +0200, Peter Krempa via Devel wrote:
...
From: Peter Krempa <pkrempa@redhat.com>
Commit 84bb136c31e added code that intended to skip the save of
transient domains but did so only in the setup part where we pause the
VMS. The second loop that actually attempts to save the VM was not
modified so we'd still try saving them:
Jul 03 14:15:13 andariel virtqemud[247210]: auto-shutdown: unable to perform managed save of 'cd3': Requested operation is not valid: cannot do managed save for transient domain
Fixes: 84bb136c31e
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 src/hypervisor/domain_driver.c | 4 ++++
 1 file changed, 4 insertions(+)
Reviewed-by: Pavel Hrdina <phrdina@redhat.com>