Re: [libvirt] [PATCH v3 3/7] qemu monitor: add multithread compress parameters accessors

On Thu, Jan 28, 2016 at 10:04:29 +0300, Nikolay Shirokovskiy wrote: > From: ShaoHe Feng <shaohe.feng(a)intel.com&gt; > > Current compression does not use all range of parameter values > so let's use some of them as 'unspecified' values. These > values will be used to mark parameters that were not specified > on migrate command line. Thus we check that qemu does not > use these values when we read parameters. > > Signed-off-by: ShaoHe Feng <shaohe.feng(a)intel.com&gt; > Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy(a)virtuozzo.com&gt; > --- > src/qemu/qemu_monitor.c | 29 +++++++++++++ > src/qemu/qemu_monitor.h | 16 +++++++ > src/qemu/qemu_monitor_json.c | 87 +++++++++++++++++++++++++++++++++++++ > src/qemu/qemu_monitor_json.h | 5 +++ > src/qemu/qemu_monitor_text.c | 100 +++++++++++++++++++++++++++++++++++++++++++ > src/qemu/qemu_monitor_text.h | 5 +++ > > > int > +qemuMonitorGetMigrationCompressParametersMT(qemuMonitorPtr mon, > + qemuMonitorMigrationMTParametersPtr params) I think a more general qemuMonitor[GS]etMigrationParameters [gs]etting all parameters at once would be a bit better. After all, it all boils down to query-migrate-parameters and migrate-set-parameters and having separate functions for each group of parameters would mean we'd have to call the QMP commands several times.

> +int qemuMonitorJSONSetMigrationCompressParametersMT(qemuMonitorPtr mon, > + qemuMonitorMigrationMTParametersPtr params) > +{ > + int ret = -1; > + virJSONValuePtr cmd; > + virJSONValuePtr reply = NULL; > + > + cmd = qemuMonitorJSONMakeCommand("migrate-set-parameters", > + "i:compress-level", params->level, > + "u:compress-threads", params->threads, > + "u:decompress-threads", params->dthreads, > + NULL); Is passing an "undefined" value for any of these parameters allowed (i.e., will QEMU use a default value) or do we always have to set all of them?