Re: [libvirt] [PATCH v2 0/8]: Add arbitrary qemu command-line and monitor commands

On Wed, Apr 28, 2010 at 04:20:45PM -0400, Chris Lalancette wrote: > As we discussed previously, here is the patch series to add the ability > to specify arbitrary qemu command-line parameters and environment variables, > and also give arbitrary monitor commands to a guest. Because these > extra arguments have a good shot at confusing libvirt, the use of them > is not supported, but left available for advanced users and developers. > They are also in a separate library and have a separate on-the-wire > protocol. > > There is one bug left that I have not yet been able to fix. Because of the > complicated way that virsh parses command-line arguments, it is not possible > to pass through spaces and quotes when using the qemu-monitor-command. > Unfortunately, the qemu monitor commands (and in particular when using QMP) > depend heavily on quoting and spacing, so using virsh to send through > command-lines is difficult. I'll have to think about how to better resolve > this issue, but it should not hold up the rest of the series. > > Thanks to Dan Berrange and Eric Blake for their reviews already, and to DV > for the Relax NG schema changes. I glanced (very) quickly at the patches and this looks sane to me, but since that should wait after 0.8.1 release I assume my full review can wait until monday, okay ?