On Wed, Feb 06, 2008 at 03:23:50PM +0100, Guido Guenther wrote:
I just noticed that the patch got mangled, sorry: On Tue, Feb 05, 2008 at 01:09:15PM +0100, Guido Guenther wrote:
That said it might also be worthwhile to not let libvirtd segfault because of a missing call to qemudReportError - this is debatable though:
diff --git a/src/qemu_conf.c b/src/qemu_conf.c index 6e4f39c..e382afa 100644 --- a/src/qemu_conf.c +++ b/src/qemu_conf.c @@ -2524,7 +2524,7 @@ qemudLoadConfig(struct qemud_driver *driver, if (!(def = qemudParseVMDef(NULL, driver, xml, file))) { virErrorPtr err = virGetLastError(); qemudLog(QEMUD_WARN, "Error parsing QEMU guest config '%s' : %s", - path, err->message); + path, err ? err->message : "BUG: unknown error - please report\n"); return NULL; }
Okay, I have applied both patches, which just a bit of reformating, thanks ! Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/