Re: [libvirt] [PATCH] build: follow directory install conventions
On 12/12/2011 09:49 AM, Michal Privoznik wrote:
On 09.12.2011 19:08, Eric Blake wrote:
> make uninstall failed:
>
> rmdir: failed to remove `/etc/sasl2/': Directory not empty
Well, this part of the commit message is no longer valid, so I tweaked
it a bit...
>
> Fix this by following the conventions already present in
> src/Makefile.am of installing with MKDIR_P, and cleaning up
> any directory in a builtroot while allowing the directory to
> still exist if non-empty in an installed system.
>
> Reported by Dave Allan.
>
ACK, and sorry for not noticing Dave's self-NACK as my e-mail filters
put his e-mail into a different folder.
At any rate, thanks for the review, and I've now pushed the rest of the
cleanups.
commit 75850b177957666ae17902fb8c0b9e930912d94f
Author: Eric Blake <eblake(a)redhat.com>
Date: Fri Dec 9 11:06:19 2011 -0700
build: follow directory install conventions
Commit 4d9e51f6 fixed a 'make uninstall' failure, but failed
to follow other conventions already present in src/Makefile.am.
In particular, we prefer MKDIR_P over mkdir -p, and should
have a matching rmdir during uninstall for every directory
created during install (the idea being that uninstall in a
DESTDIR should be clean, while installation in the final
system should not fail with non-empty directories left behind).
--
Eric Blake eblake(a)redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 620 bytes)