Re: [libvirt] [PATCH] libxl: add discard support to libxl_device_disk

On Mon, Jul 07, Daniel P. Berrange wrote:

IIUC, this is not about the underlying storage, but about whether the hypervisor API supports the discard setting. The libvirt policy is to always raise VIR_ERR_CONFIG_UNSUPPORTED and return failure to the app if they request a setting that the hypervisor does not support. Whether discard is critical or not really depends on your POV, so it is better not to make such assumptions on behalf of the mgmt app.

So how should the code path error out in this case? Olaf