Re: [libvirt] [PATCH v2 00/12] qemu: Fix media changing problems

Fixes regression in media changing/disk hotplug as the ordering of the alias allocation and disk preparation was bad. v2: - be more explicit about old and new definitions used in certain steps - clean up legacy hotplug to not access old disk source definition - also treat network disks as 'raw' if the format was not provided Peter Krempa (12): Revert "qemu: hotplug: Prepare disk source in qemuDomainAttachDeviceDiskLive" Revert "qemu: hotplug: consolidate media change code paths" qemu: hotplug: Don't pretend that we support secrets for media change qemu: domain: Assume 'raw' default storage format also for network storage qemu: hotplug: Remove code handling possible missing disk source format qemu: hotplug: Allow specifying explicit source for disk backend hotplug code qemu: hotplug: Be explicit about old/new sources when changing media qemu: hotplug: Prepare disk source for media changing qemu: hotplug: Add wrapper for disk hotplug code qemu: conf: Export qemuAddSharedDisk qemu: hotplug: Split out media change code from disk hotplug qemu: hotplug: Refactor qemuDomainAttachDeviceDiskLiveInternal src/qemu/qemu_conf.c | 2 +- src/qemu/qemu_conf.h | 5 + src/qemu/qemu_domain.c | 4 +- src/qemu/qemu_driver.c | 7 +- src/qemu/qemu_hotplug.c | 276 ++++++++++-------- src/qemu/qemu_hotplug.h | 9 +- tests/qemuhotplugtest.c | 2 +- .../disk-source-pool-mode.args | 6 +- tests/qemuxml2argvdata/disk-source-pool.args | 4 +- .../disk-source-pool-mode.xml | 6 +- tests/qemuxml2xmloutdata/disk-source-pool.xml | 2 +- 11 files changed, 185 insertions(+), 138 deletions(-)