On 21/03/19 14:04, Peter Maydell wrote:
were then removed in commit 9483cf27dd36 ("hppa-softmmu.mak: express dependencies with Kconfig", 2019-03-07) and commit 87f9108bad0c ("ppc64: Express dependencies of 'pseries' and 'powernv' machines with kconfig", 2019-03-07), from files
default-configs/hppa-softmmu.mak default-configs/ppc64-softmmu.mak
respectively.
Therefore I think commit 7c28b925b7e1 has the bug. The VIRTIO_VGA restriction
depends on VIRTIO_PCI
should now be replaced with
depends on VIRTIO_PCI && (PC || DINO || PSERIES)
Should it? What makes the virtio-vga device only suitable for those three machines?
The idea was that to only support virtio-vga for those machines where the firmware doesn't know about virtio-gpu and supported VGA legacy hardware before virtio-{gpu,vga} were introduced. I think this is a bug in libvirt, but at least for 4.0 it should be fixed/worked around in QEMU. Paolo