On Wed, May 05, 2021 at 04:15:44PM +0200, Michal Privoznik wrote:
While reworking the patch I've mistakenly mangled the attribute names for VIR_DOMAIN_CHR_TYPE_NMDM.
Signed-off-by: Michal Privoznik <mprivozn@redhat.com> --- src/conf/domain_conf.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index d5d8bd0a01..3319cb49cf 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -11314,7 +11314,7 @@ virDomainChrSourceDefParseXML(virDomainChrSourceDef *def, int nsources = 0; VIR_XPATH_NODE_AUTORESTORE(ctxt)
- ctxt->node = cur; + ctxt->node = cur;
if ((nsources = virXPathNodeSet("./source", ctxt, &sources)) < 0) { goto error; @@ -11372,8 +11372,8 @@ virDomainChrSourceDefParseXML(virDomainChrSourceDef *def, break;
case VIR_DOMAIN_CHR_TYPE_NMDM: - def->data.nmdm.master = virXMLPropString(sources[0], "master)"); - def->data.nmdm.slave = virXMLPropString(sources[0], "slave)"); + def->data.nmdm.master = virXMLPropString(sources[0], "master"); + def->data.nmdm.slave = virXMLPropString(sources[0], "slave");
Heh, fun typo. Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|