Re: [libvirt] [PATCH 1/3] virAuth: Don't require virConnectPtr to retrieve authentication creds

On Wed, Jul 10, 2013 at 08:42:03AM +0200, Peter Krempa wrote: > Previously a connection object was required to retrieve the auth > credentials. This patch adds the option to call the retrieval functions > only using the connection URI or path to the configuration file. This > will allow to use this toolkit to request passwords for ssh > authentication in the libssh2 connection driver. > > Changes: > *virAuthGetConfigFilePathURI(): use URI to retrieve the config file path > *virAuthGetCredential(): Remove the need to propagate conn object > > virAuthGetPasswordPath(): > *virAuthGetUsernamePath(): New functions, that use config file path > instead of conn object > --- > src/util/virauth.c | 107 +++++++++++++++++++++++++++++++++++++---------------- > src/util/virauth.h | 17 ++++++++- > 2 files changed, 91 insertions(+), 33 deletions(-) ACK I won't force you to write a test case for this, since we don't already have a test virauth.h file APIs. If you should wish to write one anyway though.....

Daniel