Re: [PATCH 22/30] util: remove cleanup labels

24 Nov 2020

On a Monday in 2020, Ryan Gahagan wrote:
...
From: Barrett Schonefeld <bschoney@utexas.edu>
- src/util/viruri.c
Signed-off-by: Barrett Schonefeld <bschoney@utexas.edu>
---
src/util/viruri.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/util/viruri.c b/src/util/viruri.c
index 704e5b2132..d49821451e 100644
--- a/src/util/viruri.c
+++ b/src/util/viruri.c
@@ -241,10 +241,9 @@ virURIFormat(virURIPtr uri)
    ret = (char *)xmlSaveUri(&xmluri);
    if (!ret) {
        virReportOOMError();
-        goto cleanup;
+        return ret;
return NULL;
...
}
- cleanup:
    return ret;
}
Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano

    