Re: [libvirt PATCH v5 0/7] cgroup and thread management in ch driver
On 2/1/22 18:22, Praveen K Paladugu wrote:
On 1/28/2022 10:05 AM, Michal Prívozník wrote:
> On 1/25/22 17:19, Praveen K Paladugu wrote:
>> This patchset adds support for cgroup management of ch threads. This
>> version
>> correctly manages cgroups for vcpu and emulator threads created by
>> ch. cgroup
>> management for iothreads is not yet supported.
>>
>> Along with cgroup management, this patchset also enables support for
>> pinning
>> vcpu and emulator threads to selected host cpus.
>>
>
> And also does a lot of formatting changes back and forth. I'm not fond
> of that really. If you want to clean up the formatting please do so in a
> separate patch(set).
Michal,
My apologies for the churn related to formatting. I ran "GNU intend"
these patches assuming that would correctly handle all the formatting.
That caused a ton of formatting issues, I tried to revert most of it.
Seems like I missed a few instances. I will pay attention to the
formatting in the follow up submissions.
Usually it helps to have your favorite editor set up so that it formats
the code as you write it. This is more or less what I have in my ~/.vimrc:
https://libvirt.org/coding-style.html#code-indentation
I took note of Persistent Def and handling of NUMA Nodeset in
cloud-hypervisor. The original author for this patch is no longer with
Microsoft. I will take some time to figure this out and submit patches
are necessary.
Alright, thank you.
Michal