Re: [PATCH 0/5] qemu: Don't abort() when creating internal snapshot with <disk type='volume'

On a Monday in 2020, Peter Krempa wrote:

See patch 5/5

Peter Krempa (5): virCommandAddArg: Don't abort on invalid input virDomainDiskTranslateSourcePool: Don't break error message in half qemuDomainSnapshotForEachQcow2Raw: Avoid a level of indentation qemuDomainSnapshotForEachQcow2Raw: Lock out operation on unsupported storage qemuDomainSnapshotForEachQcow2: Pass in 'def' rather than selecting it internally

src/conf/domain_conf.c | 3 +- src/qemu/qemu_domain.c | 102 +++++++++++++++++++++------------------ src/qemu/qemu_domain.h | 2 +- src/qemu/qemu_snapshot.c | 16 ++++-- src/util/vircommand.c | 2 +- 5 files changed, 70 insertions(+), 55 deletions(-)

Reviewed-by: Ján Tomko <jtomko@redhat.com> Jano