Re: Can you have a brief look? [Was: Support for emulated NVMe disks in VMX and QEMU]
[Adding the list to Cc]
On Fri, Jun 06, 2025 at 12:19:16PM +0800, Honglei Wang wrote:
Hi Martin,
Thanks for following up — yes, I saw your previous email and just had a
chance to review the patches.
The series looks good to me overall, and I’m fine with the Signed-off-by
trailers you added — thanks for including them.
Thank you for the confirmation.
There might be a small detail to look into: I noticed you changed the
parameters of the virIndexToDiskName function, but it seems not all callers
were updated accordingly. This should be caught by CI, though. If I have
any other issues, I’ll reply on the patch mail list.
You are right, I missed the hyperv driver for some reason. I fixed that
in the commit which changes the parameters and pushed the series
upstream so that it gets to the next release.
Thanks again for your work on this!
Best regards
Thank you too and have a nice day,
Martin
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)