Re: [libvirt] [PATCH] maint: avoid comparisons to bool constants

2011/5/5 Eric Blake <eblake(a)redhat.com&gt;: > HACKING already mentions that comparisons against literal 'true' > are unsafe; for consistency, also shorten comparisons against 'false'. > > * src/conf/domain_conf.c (virDomainNetDefParseXML): Simplify. > * src/nwfilter/nwfilter_gentech_driver.c > (virNWFilterDomainFWUpdateCB): Likewise. > * tools/virsh.c (cmdVolDownload, vshCommandRun, vshPrintExtra): > Likewise. > --- > src/conf/domain_conf.c | 2 +- > src/nwfilter/nwfilter_gentech_driver.c | 2 +- > tools/virsh.c | 8 ++++---- > 3 files changed, 6 insertions(+), 6 deletions(-) > ACK.