14.01.2016 16:01, Daniel P. Berrange пишет: [snip]
I agree we should be more explicit about this all in the docs. For initial XML config, we should just raise an error if both <memory> and <currentMemory> are present and have different values, or possibly just clamp <currentMemory> to match <memory>. Hmm. And what if a user wants a VM to be started with inflated balloon and be able to deflate it later to add some memory to the VM in runtime? If libvirt raised an error in case <memory> and <currentMemory> are present and different a user wouldn't have such a possibility.
In virDomainSetMemoryFlags() we should document that with container based virt, you cannot change the CURRENT_MEMORY setting, and with machine based virt you cannot change the MAX_MEMORY setting but containers should allow it.
Regards, Daniel