Re: [libvirt] [PATCH 1/2] qemu: Add support for changing timeout value to open unix monitor socket

On Thu, Jan 09, 2014 at 09:22:05AM +0100, Martin Kletzander wrote: > From: Pavel Fux <pavel(a)stratoscale.com&gt; > > Adding an option to change monitor socket opening timeout > the current default is 3 seconds and in some cases it's not enough > > Signed-off-by: Pavel Fux <pavel(a)stratoscale.com&gt; > Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com&gt; > --- > > Notes: > I modified the description in the config file, made the use of the > opaque argument in qemuMonitorOpen and rebased it on current master. > > I also added the config options in augeas test to make the 'make > check' pass. IMHO we shouldn't add this config parameter. This kind of parameter is basically saying "our code doesn't work by default, set this to fix it" which is just horrible behaviour. Further more an admin won't even find out about this until the worst possible time. Just increase the default timeout if we need to. Even better would be to figure out how we can properly fix this to avoid any need for timeout at all.

Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list(a)redhat.com https://www.redhat.com/mailman/listinfo/libvir-list