On 02/06/2014 08:18 AM, Pavel Hrdina wrote:
The coverity server complains about the dev->stubDriver that it was freed by the virPCIDeviceSetStubDriver function, but it somehow don't get the fact that into the variable is immediately assigned new string.
Signed-off-by: Pavel Hrdina <phrdina@redhat.com> --- tests/virpcitest.c | 2 ++ 1 file changed, 2 insertions(+)
What's the exact complaint?
diff --git a/tests/virpcitest.c b/tests/virpcitest.c index 994b300..8ff3b1d 100644 --- a/tests/virpcitest.c +++ b/tests/virpcitest.c @@ -248,6 +248,7 @@ testVirPCIDeviceDetachSingle(const void *opaque) if (!dev) goto cleanup;
+ /* coverity[freed_arg] */ if (virPCIDeviceSetStubDriver(dev, "pci-stub") < 0 || virPCIDeviceDetach(dev, NULL, NULL) < 0) goto cleanup;
Is this something where an sa_assert() could do the trick in a more tool-agnostic manner? -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org