Re: [libvirt] [PATCH] OpenNebula driver changes

On Thu, Jun 04, 2009 at 12:14:44PM +0100, Daniel P. Berrange wrote: > On Wed, Jun 03, 2009 at 06:42:37PM +0200, Javier Fontan wrote: > > Hello, > > > > The first patch makes OpenNebula driver compilable in recent codebase. > > The second one adds direct calls to xmlrpc library so it does not > > depend on OpenNebula libraries and can be licensed as LGPL. > > This looks good. I'll just suggest that the driver is made to build by > default in configure.in, automatically looking for the xml-rpc libs > using pkg-config instead. Okay, I made the changes suggested by Dan, so it's compiled in by default, cleaned up the c code a bit to make make distcheck, I had to add the privileged parameter to the oneStartup() call, it should probably be saved in the driver structure or checked if we allow the driver only from the daemon. I added the build requirement to the spec file when compiling on Fedora so it will be built in by default. Everything look fine to me but I couldn't test the driver itself, so a bit more testing should be done before the 0.6.5 release end of next week,  it's all in CVS,  thanks ! Daniel -- Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/ daniel(a)veillard.com  | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library  http://libvirt.org/ -- Libvir-list mailing list Libvir-list(a)redhat.com https://www.redhat.com/mailman/listinfo/libvir-list