On 4/15/20 6:38 PM, Andrea Bolognani wrote:
On Wed, 2020-04-15 at 16:45 +0200, Cornelia Huck wrote:
On Wed, 15 Apr 2020 16:23:46 +0200 Boris Fiuczynski <fiuczy@linux.ibm.com> wrote:
Once I understand you confusion above I will provide a patch...
I'd say just go ahead.
While I appreciate the sentiment, I would rather not have an excessive amount of detail added to this page.
The idea behind it was to show users that they shouldn't expect the address in the domain XML to match the one in the guest OS, with a few real-life examples to illustrate the point. So, I don't think the details of how exactly zPCI IDs translate to guest-visible PCI addresses is in scope.
It would be great information to have in some other document, though! Is there something like that in qemu.git, or in the QEMU wiki? Those are the places where I would expect it to live, since it's not really tied to libvirt...
I disagree because fid is a parameter of the pci address just like domain, bus, slot, function and uid. Besides the fact that one of the first sentences in the document is "When discussing PCI addresses, it's important to understand the relationship between the addresses that can be seen in the domain XML and those that are visible inside the guest OS." as a document reader/user of libvirt I would not expect to search around in other documentation for fid if all other parameters are correlated here. So how about a short explanatory sentence for fid like: "The slot for the PCI device in the guest OS is defined by the fid (function id)." -- Mit freundlichen Grüßen/Kind regards Boris Fiuczynski IBM Deutschland Research & Development GmbH Vorsitzender des Aufsichtsrats: Gregor Pillen Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen Registergericht: Amtsgericht Stuttgart, HRB 243294