On Mon, Feb 25, 2019 at 17:39:46 +0100, Diego Michelotto wrote:
Hi Peter
Il giorno 25 feb 2019, alle ore 13:28, Peter Krempa <pkrempa@redhat.com> ha scritto:
On Mon, Feb 25, 2019 at 09:39:39 +0100, dmichelotto wrote: Added GPFS as shared file system recognized during live migration security checks.
You could mention that GPFS stands for 'IBM General Parallel File System (GPFS)'.
OK, I’ll change it.
This becomes from upstream code on https://libvirt.org/git from master branch
This should not be part of the commit message.
Ok, I’ll remove it.
BUG: https://bugzilla.redhat.com/show_bug.cgi?id=1679528 ---
Please note that the libvirt project requires that you comply with the developer certificate of origin. See https://libvirt.org/hacking.html#patches part 6 and https://developercertificate.org/.
Is it enough if I add --signoff option and my full name at the last commit?
Yes, that's exactly what we require. I just prefer wording it carefully so that I don't say "you need to add a Signed-off-by: ... line" where it might not be clear that it has a formal meaning.
Also we prefer if you use full name as the author when sending the patch.
src/util/virfile.c | 9 ++++++++- src/util/virfile.h | 1 + tests/virfiledata/mounts3.txt | 1 + tests/virfilemock.c | 5 +++++ tests/virfiletest.c | 1 + 5 files changed, 16 insertions(+), 1 deletion(-)
The changes look good to me but I'd prefer if you send the patch again including the sign-off and proper name.
I’m very sorry for my mistakes, it’s the first libvirt patch for me.
That's all right, you did good in the code department, just a few formal improvements needed.