Re: [libvirt] [PATCH] libvirt-guests: avoid globbing when splitting $URIS
On 03/14/2011 01:37 AM, Philipp Hahn wrote:
Hello Eric,
Am Freitag 11 März 2011 22:08:33 schrieb Eric Blake:
> * tools/libvirt-guests.init.sh (start, stop, gueststatus): Avoid
> shell globbing, since valid URIs can contain '?'.
Looks sane, but perhaps setting 'set -f' once at the top of the file with some
comment would fix the problem as well, but that's just a question of
personally preferred style.
I'd rather bracket the few places where we know we want to suppress
globbing than to globally disable globbing and risk breaking somewhere
else in the script that was depending on it. Unless it's easy to audit
that the entire script does not want to use globbing, but I haven't done
that audit.
At any rate, thanks for the review; I've pushed this patch now.
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 619 bytes)