On Mon, Jan 05, 2009 at 03:21:35PM +0100, Daniel Veillard wrote:
On Mon, Jan 05, 2009 at 10:27:03AM +0000, Daniel P. Berrange wrote:
On Fri, Dec 26, 2008 at 02:19:06PM +0100, Guido G?nther wrote:
> > by honoring the VIR_DOMAIN_XML_INACTIVE flag. > O.k. to commit this part as a start so you can readily use it vor lxc?
ACK, assuming 'make check' still passes. It does here, sure. Patch Applied now. I've added the flag to the functions currently needed for qemu but if nobody objects I'd like to add them to:
virDomainDeviceDefParse virDomainDefParseString virDomainHostdevSubsysUsbDefParseXML virDomainDiskDefParseXML virDomainFSDefParseXML virDomainNetDefParseXML virDomainInputDefParseXML virDomainSoundDefParseXML virDomainHostdevDefParseXML virDomainChrDefParseXML
Attached patch adds a flag parameter to the above functions and passes VIR_DOMAIN_XML_INACTIVE from the upper levels. I see two advantages in this:
* symmetric interfaces to the XML parsing functions (why has virDomainDefParseFile a flags argument while virDomainDefParseString hasn't) * other drivers can use this very easily (IIRC lxc has some use for it)
otherwise there's not too much gain so I'm a bit undecided if this is actually necessary.
ACK
Sounds fine to me too, Applied now. -- Guido