Re: [libvirt] [PATCH 2/8] qemu: Disable migration with ivshmem
On 09/27/2016 08:24 AM, Martin Kletzander wrote:
It was never safe anyway and as such shouldn't have been enabled
in the
first place. Future patches will allow hot-(un)pluging of some ivshmem
devices as a workaround.
Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com>
---
src/qemu/qemu_migration.c | 6 ++++++
1 file changed, 6 insertions(+)
Seems like a reasonable thing to disallow...
Never quite sure what the "norm" is - start message w/ capital letter or
not... I think others in the code go with lowercase... Your call.
ACK,
John
diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
index e2ca3303efd3..0d7fec8360f3 100644
--- a/src/qemu/qemu_migration.c
+++ b/src/qemu/qemu_migration.c
@@ -2346,6 +2346,12 @@ qemuMigrationIsAllowed(virQEMUDriverPtr driver,
return false;
}
}
+
+ if (vm->def->nshmems) {
+ virReportError(VIR_ERR_OPERATION_INVALID, "%s",
+ _("Migration with shmem device is not
supported"));
+ return false;
+ }
}
return true;