Re: [PATCH 00/21] qemu: Refactor domstats code to avoid error reporting
On Mon, Feb 24, 2025 at 10:42:05 +0100, Peter Krempa wrote:
On Mon, Feb 24, 2025 at 09:33:51 +0000, Daniel P. Berrangé wrote:
> On Thu, Feb 20, 2025 at 10:01:13AM +0100, Peter Krempa wrote:
> > The workers of qemuDomainGetStats should not report errors if they can't
> > fetch data; but rather omit the entries. Refactor the code to
> > de-incentivize error reporting.
>
> Why shouldn't they report errors ?
N.B: The error reporting infrastructure that was present and is removed
by this patch existed solely for reporting allocation errors when adding
the results to the list and the originally implemnted workers never
reported errors when fetching actual data; just irrecoverable
daemon-side errors.
It's just the new workers that did report errors, which was very likely
based on the fact that the callback function did require an error code
to be returned.