Re: [libvirt] [PATCH v2 1/4] storage: Introduce storagePoolLookupByPath

On 12/01/14 15:57, Michal Privoznik wrote: A comment describing how this works (mention that only active pools are found), or ... .. rename to LookupByTargetPath perhaps? > + const char *path) > +{ > + size_t i; > + virStoragePoolPtr ret = NULL; > + char *cleanpath; > + > + cleanpath = virFileSanitizePath(path); > + if (!cleanpath) > + return NULL; > + > + storageDriverLock(); > + for (i = 0; i < driver->pools.count && !ret; i++) { > + virStoragePoolObjPtr pool = driver->pools.objs[i]; > + > + virStoragePoolObjLock(pool); > + > + if (!virStoragePoolObjIsActive(pool)) { > + virStoragePoolObjUnlock(pool); > + continue; > + } > + > + if (STREQ(path, pool->def->target.path)) { > + ret = virGetStoragePool(conn, pool->def->name, pool->def->uuid, > + NULL, NULL); > + } > + > + virStoragePoolObjUnlock(pool); > + } > + > + VIR_FREE(cleanpath); > + storageDriverUnlock(); > + return ret; > +} > + > > static int > storageVolDeleteInternal(virStorageVolPtr obj, > diff --git a/src/storage/storage_driver.h b/src/storage/storage_driver.h > index b805ddd..b51760a 100644 > --- a/src/storage/storage_driver.h > +++ b/src/storage/storage_driver.h > @@ -57,6 +57,10 @@ int virStorageFileGetMetadata(virStorageSourcePtr src, > int virStorageTranslateDiskSourcePool(virConnectPtr conn, > virDomainDiskDefPtr def); > > + const char *path); Add ATTRIBUTE_NONNULL(2) ACK with the attribute and a comment about the usage of this func added. Peter