Re: [libvirt] [PATCH] check "fc_host" and "vport_ops" capabilities in SCSI host nodedevs
On Thu, Feb 5, 2015 at 6:13 PM, John Ferlan <jferlan(a)redhat.com> wrote:
<...snip...>
>
> Had a chance to try your patch.
>
> # cat testCaps.py
> import libvirt
> conn = libvirt.openReadOnly('qemu:///system')
> fc = conn.nodeDeviceLookupByName('scsi_host1')
> caps = fc.listCaps();
> print "The capabilities are", caps
> nCaps = fc.numOfCaps();
> print "The number of Caps : ", nCaps
>
> # ./run python testCaps.py
> The capabilities are ['scsi_host', 'fc_host', 'vports']
> The number of Caps : 3
>
Excellent - thanks... I "assume" prior to my patch the result would
just be 'scsi_host' and 1 for number of caps...
Yes it is.. :)
# python testCaps.py
The capabilities are ['scsi_host']
The num of Caps : 1
> Given the above output(also virsh behaviour), I am thinking my patch should
> actually be checking the string "vports" instead of "vport_ops".
>
> I am sending you the v2 with that change. Feel free to change the commit
> message as appropriate.
>
I can edit your existing patch in my git branch to change "vport_ops" to
"vports" - that's not a problem...
Thanks for offering to edit my patch.
Regards,
Shiva
John