Re: [libvirt] [PATCH] appdev-guide/Connections: Remove duplicated entries
On Fri, Jun 22, 2018 at 05:44:18PM -0300, Marcos Paulo de Souza wrote:
On Mon, Jun 25, 2018 at 01:35:33PM +0200, Erik Skultety wrote:
> On Sat, Jun 23, 2018 at 11:32:55AM -0300, Marcos Paulo de Souza wrote:
> > Both /hosts/cpu/arch and /hosts/cpu/features appear twice in the
documentation.
> >
> > Signed-off-by: Marcos Paulo de Souza <marcos.souza.org(a)gmail.com>
> > ---
> >
> > This is my first submission to libvirt, so let me know if I forgot something.
>
> Which repo is this patch against?
This patch is againt the appdev-guide located here:
https://libvirt.org/git/?p=libvirt-appdev-guide.git;a=summary
The repository seems to be the source of the documenation located in
libvirt.org:
https://libvirt.org/devguide.html
Is there other place to send patches for appdev-guide?
No, but usually we change patch subject prefix to PATCH-project so that it's
obvious which project you're sending the patch against, because from the commit
subject itself it's not apparent at first sight, especially when noone has
touched that git for over 6 years. The document itself was never even finished
and regarding the publican we basically it by moving the static content to the
main repo. Anyhow, I'm fairly sceptical anyone ever used the development guide
solely because of how much it's missing, so I don't know how much sense it makes
to push the patch and whether we keep building the repo so that the change
would actually be propagated, even though it's correct, but Dan will know the
answer for sure, so I'm CCing him.
Erik