Re: [libvirt] [PATCH 1/4] parallels: add VIR_STORAGE_FILE_PLOOP format

On Wed, May 07, 2014 at 10:04:06PM +0400, Dmitry Guryanov wrote: > Add VIR_STORAGE_FILE_PLOOP format. This format is used > to store disk images for virtual machines in PCS and containers > in PCS, OpenVZ and also in Parallels Desktop for Mac. > > This format is described on OpenVZ site - > https://openvz.org/Ploop (together with ploop devices). It > consists of XML descriptor and one or more image files: base > image and deltas. Format of the image files described here: > https://openvz.org/Ploop/format. > > This patch only adds VIR_STORAGE_FILE_PLOOP constant, consequent > patches will use it in parallels driver. > > Signed-off-by: Dmitry Guryanov <dguryanov(a)parallels.com&gt; > --- > > src/util/virstoragefile.c | 4 +++- > src/util/virstoragefile.h | 1 + > 2 files changed, 4 insertions(+), 1 deletion(-) > > diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c > index 96af27b..5c1ab62 100644 > --- a/src/util/virstoragefile.c > +++ b/src/util/virstoragefile.c > @@ -62,7 +62,7 @@ VIR_ENUM_IMPL(virStorageFileFormat, > > "cloop", "dmg", "iso", > "vpc", "vdi", > /* Not direct file formats, but used for various drivers */ > > - "fat", "vhd", > + "fat", "vhd", "ploop", > > /* Formats with backing file below here */ > "cow", "qcow", "qcow2", "qed", "vmdk") > > @@ -230,6 +230,8 @@ static struct FileTypeInfo const fileTypeInfo[] = { > > -1, {0}, 0, 0, 0, 0, NULL, NULL }, > > [VIR_STORAGE_FILE_VHD] = { 0, NULL, NULL, LV_LITTLE_ENDIAN, > > -1, {0}, 0, 0, 0, 0, NULL, NULL }, > > + [VIR_STORAGE_FILE_PLOOP] = { 0, NULL, NULL, LV_LITTLE_ENDIAN, > + -1, {0}, 0, 0, 0, 0, NULL, NULL }, Is there no magic byte sequence to identify the ploop image format ?

ACK if there is none. Regards, Daniel