Re: [libvirt] [PATCH v2] qemu: bulk stats: implement (cpu) tune group.

From: "Peter Krempa" <pkrempa(a)redhat.com&gt; To: "Francesco Romani" <fromani(a)redhat.com&gt; Cc: libvir-list(a)redhat.com Sent: Monday, March 9, 2015 2:16:34 PM Subject: Re: [libvirt] [PATCH v2] qemu: bulk stats: implement (cpu) tune group.

> + * VIR_DOMAIN_STATS_TUNE_CPU: Return CPU tuning statistics > + * and usage information. > + * The typed parameter keys are in this format: > + * "tune.vcpu.quota" - max allowed bandwidth, in microseconds, as > + * long long integer. -1 means 'infinite'. > + * "tune.vcpu.period" - timeframe on which the virtual cpu quota is > + * enforced, in microseconds, as unsigned long long. > + * "tune.emu.quota" - max allowed bandwidth for emulator threads, > + * in microseconds, as long long integer. > + * -1 means 'infinite'. > + * "tune.emu.period" - timeframe on which the emulator quota is > + * enforced, in microseconds, as unsigned long long. > + * "tune.cpu.shares" - weight of this domain. This value is meaningful > + * only if compared with the other values of > + * the running domains. Expressed as unsigned long > long. > + * These options above represent configuration and not any statistic value, so they won't change unless libvirt is instructed to change them. I don't think they belong to the stats API. Additionally libvirt recently added an event to track change of the tunables. See virConnectDomainEventTunableCallback. http://libvirt.org/html/libvirt-libvirt-domain.html#virConnectDomainEvent... http://libvirt.org/html/libvirt-libvirt-domain.html#VIR_DOMAIN_TUNABLE_CP... http://libvirt.org/html/libvirt-libvirt-domain.html#VIR_DOMAIN_TUNABLE_CP... and so on ... I think you want to use that event and leave this api for statistics only.