Re: [libvirt] [PATCH 06/13] qemu: Refactor qemuDomainGetChardevTLSObjects to converge code

On Fri, Feb 17, 2017 at 14:39:23 -0500, John Ferlan wrote:

Create a qemuDomainAddChardevTLSObjects which will encapsulate the qemuDomainGetChardevTLSObjects and qemuDomainAddTLSObjects so that the callers don't need to worry about the props.

Move the dev->type and haveTLS checks in to the Add function to avoid an unnecessary call to qemuDomainAddTLSObjects

Signed-off-by: John Ferlan <jferlan@redhat.com> --- src/qemu/qemu_hotplug.c | 80 ++++++++++++++++++++++++++----------------------- 1 file changed, 43 insertions(+), 37 deletions(-)

This looks OK. Jirka