Re: [libvirt] [PATCH 5/6] allow non-zero success values from a domain's MigratePerform
On Wed, Oct 07, 2009 at 03:52:10PM +0200, Paolo Bonzini wrote:
>In the case of old server and new client, the client should get a RPC
>error when trying to re-serialize the reply, because the data packet
>it will be getting back from the server will be too small (ie missing
>the new field this patch adds).
>
>The RPC protocol should be considered ABI, and no existing methods
>ever changed, only new methods can be added so NACK to this patch
I had actually prepared this patch too, but after my testing I wasn't
sure if it was necessary. Would it be fine to add it to the respin?
This hack means that it would be ignoring *all* deserialization errors,
which IMHO is just as bad. This is ABI and we shouldn't try to change
it, or workaround it because it is just going to cause pain somewhere
down the line
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|