Re: [PATCH 17/24] qemucapabilitiesdata: Add (fake) '+hvf' variant of x86_64 data

On Tue, Mar 28, 2023 at 16:53:13 +0200, Peter Krempa wrote: > On Tue, Mar 21, 2023 at 16:13:22 +0100, Martin Kletzander wrote: > > On Thu, Mar 16, 2023 at 05:11:46PM +0100, Peter Krempa wrote: > > > The data is based on the generic variant of the 7.2.0 data on x86_64. > > > > > > Only modification to the '.replies' file is that KVM is reported as > > > unavailable/unsupported. > > > > > > Ideally this will be replaced by a dump captured from a real system. > > > > > > Signed-off-by: Peter Krempa <pkrempa(a)redhat.com&gt; > > > --- > > > .../qemu_7.2.0-hvf.x86_64+hvf.xml | 183 + > > > .../qemu_7.2.0-tcg.x86_64+hvf.xml | 264 + > > > .../caps_7.2.0_x86_64+hvf.replies | 39399 ++++++++++++++++ > > > .../caps_7.2.0_x86_64+hvf.xml | 3250 ++ > > > tests/qemucaps2xmloutdata/caps.x86_64+hvf.xml | 28 + > > > 5 files changed, 43124 insertions(+) > > > create mode 100644 tests/domaincapsdata/qemu_7.2.0-hvf.x86_64+hvf.xml > > > create mode 100644 tests/domaincapsdata/qemu_7.2.0-tcg.x86_64+hvf.xml > > > create mode 100644 tests/qemucapabilitiesdata/caps_7.2.0_x86_64+hvf.replies > > > create mode 100644 tests/qemucapabilitiesdata/caps_7.2.0_x86_64+hvf.xml > > > create mode 100644 tests/qemucaps2xmloutdata/caps.x86_64+hvf.xml [...] > > ... this is still kept in. Thankfully we do not base anything on it, I > > don't think. > > > > Anyway, enough of the silliness. Could we get the real dump from CI > > somehow? Or is there a need to build the qemu there just for this? > > I made a (poor) attempt at grabbing it from the CI but failed. Possibly > we don't have access to the hypervisor in cirrus. I can give it another > try, but otherwise I don't have a OSX machine around. Thanks to your suggestion to run the cirrus job with a terminal I made a bit better attempt now and unfortunately the environment in cirrus doesn't support virtualization, thus the capabilities can't be grabbed. Once the release is out I'll go ahead with this patch. We can replace it once we get a proper dump. This patchset should allow users with a mac to do so.