Re: [libvirt PATCH 07/11] qemu: start/stop an event thread for QMP probing
On Fri, Feb 14, 2020 at 02:03:59PM +0100, Ján Tomko wrote:
On Fri, Feb 14, 2020 at 12:52:05PM +0000, Daniel P. Berrangé wrote:
> In common with regular QEMU guests, the QMP probing
> will need an event loop for handling monitor I/O
> operations.
>
> Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com>
> ---
> src/qemu/qemu_process.c | 16 ++++++++++++++++
> src/qemu/qemu_process.h | 2 ++
> 2 files changed, 18 insertions(+)
>
> @@ -8408,6 +8411,9 @@ qemuProcessQMPNew(const char *binary,
> {
> qemuProcessQMPPtr ret = NULL;
> qemuProcessQMPPtr proc = NULL;
> + g_autoptr(GError) gerr = NULL;
Fails to build with Clang:
../../src/qemu/qemu_process.c:8416:23: error: unused variable 'gerr'
[-Werror,-Wunused-variable]
g_autoptr(GError) gerr = NULL;
^
Opps, left over from earlier version
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|