Re: [libvirt] [libvirt-glib 3/3] gconfig: Add GVirConfigDomainSnapshot getters/setters

On Thu, May 02, 2013 at 06:33:44PM +0300, Zeeshan Ali (Khattak) wrote: > On Wed, May 1, 2013 at 10:59 PM, Christophe Fergeau <cfergeau(a)redhat.com&gt; wrote: > > + > > + > > +const char *gvir_config_domain_snapshot_get_parent(GVirConfigDomainSnapshot *snapshot) > > +{ > > Shouldn't this be returning a GVirConfigDomainSnapshot instance? Hmm, that's a good point, this is made a bit tricky because of the "Older versions of libvirt stored only a single child element, uuid". This was changed in 2011 for libvirt 0.9.5 by http://libvirt.org/git/?p=libvirt.git;a=commit;h=f609cb85ca11d6d178972e46... Given that we already require libvirt 0.10.2, I'd say it's fine to ignore this 'older version' case.