Re: [libvirt] [PATCH] Add some news items for the 3.4.0 release

On Wed, 2017-05-31 at 17:44 +0200, Martin Kletzander wrote: > > @@ -407,7 +404,7 @@ > >           NVDIMM is new type of memory introduced into QEMU 2.6. The idea is > >           that we have a non-volatile memory module that keeps the data > >           persistent across domain reboots and offers much faster data > > -          accesses.  However, due to a bug in QEMU, this feature is not enabled > > +          accesses. However, due to a bug in QEMU, this feature is not enabled > >           for QEMUs older than 2.9.0. >  > Of course except this last hunk as that is for an older version, I'm > rushing too much, I'll rather send a v2 tomorrow then regret the bunny > ears yet again. I don't feel like news entries become entirely immutable after the release is out; in particular, performing minor style tweaks like this one or fixing typos is perfectly acceptable IMHO, as it improves the overall document without changing its meaning or attempting to rewrite history.

And I'm pretty sure removing an extra space from this file will not cause the build to fail, so no risk of bunny ears ;) --  Andrea Bolognani / Red Hat / Virtualization