Re: [libvirt] [PATCH 1/1] Clarify the purpose of domxml-from-native (v2)

On 02/06/2012 03:17 PM, Dave Allan wrote: > Someone mentioned to me that they interpreted this section of the KVM > driver page as suggesting that new guests should be created by > creating a qemu commandline and converting it to XML with > domxml-from-native. I don't think that's the intent of > domxml-from-native, so I added that clarification. > > v2 > Suggstion from eblake: Add link to the applications page s/Suggstion/Suggestion/ actually, I removed that line from the commit message (v2 information fits better after the --- line, since it is helpful for review, but doesn't need to be enshrined for eternity in the 'git log').

> + The <code>virsh domxml-from-native</code> provides a way to > + convert an existing set of QEMU args into a guest description > + using libvirt Domain XML that can then be used by libvirt. > + Please note that this command is intended to be used to convert > + existing qemu guests previously started from the command line to > + be managed through libvirt. It should not be used a method of > + creating new guests from scratch. New guests should be created > + using an application calling the libvirt APIs (see > + the <a href="apps.html">libvirt applications page</a> for some > + examples) or by manually crafting XML to pass to virsh. ACK and pushed.

-- Eric Blake eblake(a)redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org