Re: [libvirt] [PATCH v2 1/4] network: add platform driver callbacks around firewall reload

On 12/7/18 11:21 AM, Daniel P. Berrangé wrote: > Allow the platform driver impls to run logic before and after the > firewall reload process. > > Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com&gt; > --- > src/network/bridge_driver.c | 13 ++++++++----- > src/network/bridge_driver_linux.c | 11 +++++++++++ > src/network/bridge_driver_nop.c | 11 +++++++++++ > src/network/bridge_driver_platform.h | 3 +++ > 4 files changed, 33 insertions(+), 5 deletions(-) > > diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c > index 4bbc4f5a6d..11095bf974 100644 > --- a/src/network/bridge_driver.c > +++ b/src/network/bridge_driver.c > @@ -165,7 +165,7 @@ static int > networkShutdownNetworkExternal(virNetworkObjPtr obj); > static void > -networkReloadFirewallRules(virNetworkDriverStatePtr driver); > +networkReloadFirewallRules(virNetworkDriverStatePtr driver, bool startup); > static void > networkRefreshDaemons(virNetworkDriverStatePtr driver); > @@ -553,7 +553,7 @@ firewalld_dbus_filter_bridge(DBusConnection *connection ATTRIBUTE_UNUSED, > "Reloaded")) > { > VIR_DEBUG("Reload in bridge_driver because of firewalld."); > - networkReloadFirewallRules(driver); > + networkReloadFirewallRules(driver, false); Okay, I think I get what you're doing here - you wanted a place to put code that would only be run once when libvirtd starts, and not when the rules are reloaded due to firewalld restarting, right? But doesn't a restart of firewalld also remove all the private chains? Or did I miss the point? I guess I must have, because when I built with these patches and tried restarting firewalld, I still saw the private chains after the restart.

So, since your method seems to work, and this code is all very straightforward: Reviewed-by: Laine Stump <laine(a)laine.org&gt;