Re: [libvirt] [PATCHv2 1/2] DUPLICATE: util: Add function to check if a virStorageSource is "empty"
On 09/12/2014 01:43 AM, Peter Krempa wrote:
>
>> + * Returns true if @src points to an empty storage source.
>> + */
>> +bool
>> +virStorageSourceIsEmpty(virStorageSourcePtr src)
>
> Maybe the comment is better as:
>
> Returns true if the guest disk has no associated host storage source
> (such as an empty cdrom drive).
>
Sounds better. I've changed the comment and pushed this patch.
Even more bikeshedding ideas (but don't worry about it, since you
already pushed):
virStorageSourceNoMedia() Returns true if a guest disk has no media
(that is, no associated host storage source)
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 539 bytes)