On 07/31/2012 04:06 AM, Daniel P. Berrange wrote:
From: "Daniel P. Berrange" <berrange@redhat.com>
The nwfilter and secrets drivers are both stateful and are already linked directly to libvirtd. Linking them to libvirt.so is thus wrong, likewise exporting their symbols in libvirt.so is wrong --- src/Makefile.am | 11 ++++------- src/libvirt_nwfilter.syms | 12 ------------ src/libvirt_private.syms | 31 ------------------------------- 3 files changed, 4 insertions(+), 50 deletions(-) delete mode 100644 src/libvirt_nwfilter.syms
Unfortunately, this patch breaks 'make check', although I haven't figured out why: $ make && make -C tests check TESTS=virdrivermoduletest VIR_TEST_DEBUG=1 ... TEST: virdrivermoduletest 1) Test driver "network" ... OK 2) Test driver "storage" ... OK 3) Test driver "nodedev" ... OK 4) Test driver "secret" ... OK 5) Test driver "nwfilter" ... OK 6) Test driver "interface" ... OK 7) Test driver "qemu" ... FAILED 8) Test driver "lxc" ... FAILED 9) Test driver "uml" ... OK FAIL: virdrivermoduletest ======================================= 1 of 1 test failed -- Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org