On 11/13/19 9:20 AM, Michal Privoznik wrote:
On 11/12/19 11:17 PM, Jim Fehlig wrote:
On 11/11/19 9:42 AM, Michal Privoznik wrote:
There are two ways for specifying loader:nvram pairs:
1) --with-loader-nvram configure option 2) nvram variable in qemu.conf
Since we have FW descriptors, using this old style is discouraged, but not as strong as one would expect. Produce more warnings:
Oh, I didn't know the old style was discouraged when using FW descriptors. Thanks for mentioning it!
1) produce a warning if somebody tries the configure option 2) produce a warning if somebody sets nvram variable and at least on FW descriptor was found
The reason for producing warning in case 1) is that package maintainers, who set the configure option in the first place should start moving towards FW descriptors and abandon the configure option. After all, the warning is printed into config output only in this case.
Should the configure option be removed from the upstream spec file?
Definitely, Fedora ships FW descriptors and so does RHEL. What's the state in OpenSUSE? But I bet you have your own spec file anyway, don't you? Just like we have for Fedora and RHEL. Will post a patch tomorrow (unless you beat me to it).
I was attempting to beat you to it, but removing $LOADERS from the spec file means removing use of --with-loader-nvram configure option. Does that mean we should remove associated code from configure.ac, nuke m4/virt-loader-nvram.m4, remove DEFAULT_LOADER_NVRAM from qemu and libxl drivers, ...? It seems a bit early for that since you are just now adding the deprecation warning to virt-loader-nvram.m4 :-). Should we wait until completely removing support for the build-time FW list before nuking from the spec file? Regards, Jim