[libvirt] [RFC] cpu_map: Remove pconfig from Icelake-Server CPU model

The pconfig feature never worked, and adding "pconfig=off" to the QEMU command-line triggers a regression in QEMU 3.1.1 and 4.0.0. Signed-off-by: Eduardo Habkost <ehabkost(a)redhat.com&gt; --- I'm sending this as an RFC because I couldn't test it properly, and because I don't know what are the consequences of changing cpu_map between libvirt versions. --- src/cpu_map/x86_Icelake-Server.xml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/cpu_map/x86_Icelake-Server.xml b/src/cpu_map/x86_Icelake-Server.xml index fb15977a59..188a781282 100644 --- a/src/cpu_map/x86_Icelake-Server.xml +++ b/src/cpu_map/x86_Icelake-Server.xml @@ -56,7 +56,9 @@ <feature name='pat'/> <feature name='pcid'/> <feature name='pclmuldq'/> - <feature name='pconfig'/> + <!-- 'pconfig' was added by accident in QEMU 3.1.0 but never worked. + It was removed in QEMU 3.1.1 and 4.0.0. See QEMU commits + 76e5a4d58357 and 712f807e1965 for details --> <feature name='pdpe1gb'/> <feature name='pge'/> <feature name='pku'/> -- 2.21.0