Re: [libvirt RFCv4 03/20] iohelper: move runIO function to a separate module

On 4/28/22 2:55 PM, Daniel P. Berrangé wrote: > On Wed, Apr 27, 2022 at 11:13:22PM +0200, Claudio Fontana wrote: >> where it can be reused by other helpers. >> No changes other than the move. >> >> Signed-off-by: Claudio Fontana <cfontana(a)suse.de&gt; >> --- >> po/POTFILES.in | 1 + >> src/util/iohelper.c | 178 +---------------------------------- >> src/util/meson.build | 2 + >> src/util/runio.c | 214 +++++++++++++++++++++++++++++++++++++++++++ >> src/util/runio.h | 23 +++++ >> 5 files changed, 241 insertions(+), 177 deletions(-) >> create mode 100644 src/util/runio.c >> create mode 100644 src/util/runio.h > > > >> +off_t runIO(const char *path, int fd, int oflags); > > I think we could just put it in virfile.{ch} and call it > virFileCopyData hmmm... it is not quite as generic as the name would imply though. The API centers around a transfer between a disk (the focus of the API), and something else (pipe, socket). What about VirFileDiskCopy?