Re: [libvirt] Couple qemu driver bugs after xml refactoring

On Tue, Jul 22, 2008 at 11:42:03AM -0400, Cole Robinson wrote: > Hi all, > > I've hit a couple bugs in the qemu driver with the recent > domain xml refactoring. I've debugged them but in both > cases I'm not sure what the optimal solutions are, so I'm > just laying them out here: > > 1) Previously defining a qemu guest without a 'listen' > address specified in the graphics tag would default to > 127.0.0.1 (hardcoded in qemu_driver->vncListen). Current > xml doesn't set this default, and will build a qemu > command line with an entry like '-vnc (null):1'. Not > sure if the default should be set at the parsing level > or the driver level. There was a good reason for removing the 127.0.0.1 from the XML parsing stage, but i can't remember what it is :-) Anyway this should really be handled at the point where we build the command line in the qemu driver code