Re: [PATCH-for-9.1 v2 2/3] migration: Remove RDMA protocol handling
Philippe Mathieu-Daudé <philmd(a)linaro.org> writes:
The whole RDMA subsystem was deprecated in commit e9a54265f5
("hw/rdma: Deprecate the pvrdma device and the rdma subsystem")
released in v8.2.
Remove:
- RDMA handling from migration
- dependencies on libibumad, libibverbs and librdmacm
Keep the RAM_SAVE_FLAG_HOOK definition since it might appears
in old migration streams.
Cc: Peter Xu <peterx(a)redhat.com>
Cc: Li Zhijian <lizhijian(a)fujitsu.com>
Acked-by: Fabiano Rosas <farosas(a)suse.de>
Signed-off-by: Philippe Mathieu-Daudé <philmd(a)linaro.org>
Just to be clear, because people raised the point in the last version,
the first link in the deprecation commit links to a thread comprising
entirely of rdma migration patches. I don't see any ambiguity on whether
the deprecation was intended to include migration. There's even an ack
from Juan.
So on the basis of not reverting the previous maintainer's decision, my
Ack stands here.
We also had pretty obvious bugs ([1], [2]) in the past that would have
been caught if we had any kind of testing for the feature, so I can't
even say this thing works currently.
@Peter Xu, @Li Zhijian, what are your thoughts on this?
1- https://lore.kernel.org/r/20230920090412.726725-1-lizhijian@fujitsu.com
2-
https://lore.kernel.org/r/CAHEcVy7HXSwn4Ow_Kog+Q+TN6f_kMeiCHevz1qGM-fbxBP...