Re: [libvirt] [PATCH] tests: do not overwrite return value when filling qemuCapsCache

On Thu, Apr 14, 2016 at 01:58:51PM +0200, Ján Tomko wrote:

In qemuHotplugCreateObjects, the ret variable was filled by the value returned by qemuTestCapsCacheInsert.

If any of the functions after this assignment failed, we would still return success.

Also adjust testCompareXMLToArgvHelper, where this change is just cosmetic, because the value was overwritten right away. --- tests/qemuhotplugtest.c | 5 ++--- tests/qemuxml2argvtest.c | 5 ++--- 2 files changed, 4 insertions(+), 6 deletions(-)

ACK Pavel