Re: [libvirt] [PATCHv2 2/7] conf: tweak volume target struct details
On 04/02/2014 03:16 AM, Peter Krempa wrote:
On 04/02/14 05:04, Eric Blake wrote:
> Some preparatory work before consolidating storage volume
> structs with the rest of virstoragefile. Making these
> changes allows a volume target to be much closer to (a
> subset of) the virStorageSource struct.
>
> +++ b/src/storage/storage_backend_disk.c
> @@ -614,7 +614,7 @@ virStorageBackendDiskPartBoundaries(virStoragePoolObjPtr pool,
> *end -= (*start % cylinderSize);
> }
>
> - /* counting in byte, we want the last byte of the current sector */
> + /* counting in bytes, we want the last byte of the current sector */
Unrelated typo fix?
Yeah. I thought I factored all those out into an earlier trivial patch
(commit 17f8263) - but missed this one. But it's not completely
unrelated, as it is the code dealing with partition manipulation, and I
found it while making sure that moving the disk partition type was an
internal-only variable that I could freely move between structs.
> *end -= 1;
> VIR_DEBUG("final aligned start %llu, end %llu", *start, *end);
> return 0;
ACK
I've pushed 1-7, and am back to hacking on my RFC 8 and 9 to turn it
into something that actually matches my proposals.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 604 bytes)