Re: [libvirt] [PATCH v3 26/34] Adapt to VIR_STRDUP and VIR_STRNDUP in src/vbox/*

On 05/03/2013 04:53 PM, Michal Privoznik wrote: > --- > src/vbox/vbox_XPCOMCGlue.c | 6 +- > src/vbox/vbox_tmpl.c | 278 +++++++++++++++++++-------------------------- > 2 files changed, 117 insertions(+), 167 deletions(-) > > diff --git a/src/vbox/vbox_tmpl.c b/src/vbox/vbox_tmpl.c > index 43ddac8..4ac7b91 100644 > --- a/src/vbox/vbox_tmpl.c > +++ b/src/vbox/vbox_tmpl.c > @@ -2290,7 +2288,8 @@ static char *vboxDomainGetXMLDesc(virDomainPtr dom, unsigned int flags) { > def->virtType = VIR_DOMAIN_VIRT_VBOX; > def->id = dom->id; > memcpy(def->uuid, dom->uuid, VIR_UUID_BUFLEN); > - def->name = strdup(dom->name); > + if (VIR_STRDUP(def->name, dom->name) < 0) > + goto cleanup; Bailing out after one unsuccessful strdup? Other parts of this function don't share this defeatist attitude.